Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Springer German Styles #1343

Merged
merged 2 commits into from
Jan 20, 2015
Merged

Springer German Styles #1343

merged 2 commits into from
Jan 20, 2015

Conversation

adam3smith
Copy link
Member

#1336 for details.
Utilities update to follow

@adam3smith
Copy link
Member Author

@rmzelle -- it's late, so I'll leave this open so you can have a quick look to check I didn't do anything dumb, but it's looking good to me.

<title>Herzschrittmachertherapie + Elektrophysiologie</title>
<title-short>Herzschr Elektrophys</title-short>
<title>Herzschrittmachertherapie + Elektrophysiologie (German)</title>
<title-short>Herzschrittmachertherapie Elektrophysiologie</title-short>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new title-short we have here comes directly from the official Springer list. However, for the titles here it might not be that important...

@rmzelle
Copy link
Member

rmzelle commented Jan 19, 2015

Is default-locale="en-US" correct? All these styles have "(German)" in the title, which we normally only do for "de-DE".

@adam3smith
Copy link
Member Author

no, it's not, thanks for catching. Will fix tonight.

@adam3smith
Copy link
Member Author

fixed.

@rmzelle
Copy link
Member

rmzelle commented Jan 20, 2015

Otherwise this looks fine. You're happy with the name "springer-fachzeitschriften-medizin-psychologie"?

@adam3smith
Copy link
Member Author

yes, that's how Springer refers to them

rmzelle added a commit that referenced this pull request Jan 20, 2015
@rmzelle rmzelle merged commit fabb5ab into master Jan 20, 2015
@rmzelle rmzelle deleted the springer-german branch January 20, 2015 04:02
@zuphilip
Copy link
Member

Thank you both very much for the help on these style. We reached now 7400+ styles in the repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants