Delete adjacent space in remaining cases - Part 1 #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 18, 2015
Merged
| <text variable="publisher" suffix="."/> | ||
| <text variable="page" prefix=": " suffix=", "/> | ||
| <text macro="date" prefix=" " suffix="."/> | ||
| <group delimiter=" "> |
There was a problem hiding this comment.
could we wrap these two groups in another group with delimiter=": " and suffix="."? My concern is that you'd not get the "." if there are neither date nor pages (or is that too hypothetical?)
There was a problem hiding this comment.
No problem. I can add that group. I think we are here in the last else case, i.e. we don't even know what strange itemType we are dealing. Thus, maybe there will also be cases as you described.
|
OK, I'm done -- are you OK to fix the two other issues I note above? |
|
I fixed both issues. Thank you |
adam3smith
added a commit
that referenced
this pull request
Jan 18, 2015
Delete adjacent space in remaining cases - Part 1
|
great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have seen any pattern in the remaing cases. Thus, I will work through all of them and create maybe 2 or 3 pull requests as this one. I have encountered 3 cases which I feel we should discuss seperately and I will make individual pull requests for them.
( Reference to #1301 )