-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create INSPQ-TOPO.csl #1120
Create INSPQ-TOPO.csl #1120
Conversation
Changes done to meet the general requierements and after other comments about the similar style insititut-national-de-sante-publique-napp.csl |
The file name has an incorrect extension: "institut-national-de-sante-publique-du-quebec-topo.cs" should be "institut-national-de-sante-publique-du-quebec-topo.csl". Also please add the "medicine" field and your name, as you did for the sibling style. |
…cs to institut-national-de-sante-publique-du-quebec-topo.csl
Done. |
</choose> | ||
</if> | ||
<else> | ||
<text variable="title" prefix="« " suffix=" »,"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as in the other styles -- guillemets with quote="true"
please.
Change requests (and some questions/suggestions that may or may not be right) in line. Please update and let us know when you're done. |
Changes done. |
Sorry, I missed some notes. I have to get thru it again and let you know when its's done. |
File updated. |
File updated. |
Replace "quote" with "quotes" as attribute (line 110, 130, 134). Make sure that your style is valid, you can check here: http://validator.citationstyles.org/ |
Replacement done. |
Looks good, thanks. @zuphilip - we don't enforce indenting on initial commits. Rintze periodically runs the reindent-reorder script that takes care of this and for initial commits, it doesn't really confuse the commit history. Getting indenting right is a nightmare for people who don't use either the visual editor or a real xml editor. |
Made a tiny change to the title: 7b34b59 Thanks, @BarilG! @adam3smith, @zuphilip, it would be nice if we could offer our users some way to properly indent their styles, but this would probably work best if we used the same lxml Python library I currently use for pretty printing all repository styles, and we would need some server space for that. |
@rmzelle, @adam3smith, @zuphilip 2014-09-24 8:51 GMT-04:00 Rintze M. Zelle notifications@github.com:
|
New Style.