Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create INSPQ-TOPO.csl #1120

Merged
merged 7 commits into from
Sep 24, 2014
Merged

Conversation

BarilG
Copy link
Contributor

@BarilG BarilG commented Sep 16, 2014

New Style.

@BarilG
Copy link
Contributor Author

BarilG commented Sep 22, 2014

Changes done to meet the general requierements and after other comments about the similar style insititut-national-de-sante-publique-napp.csl

@rmzelle
Copy link
Member

rmzelle commented Sep 22, 2014

The file name has an incorrect extension: "institut-national-de-sante-publique-du-quebec-topo.cs" should be "institut-national-de-sante-publique-du-quebec-topo.csl".

Also please add the "medicine" field and your name, as you did for the sibling style.

…cs to institut-national-de-sante-publique-du-quebec-topo.csl
@BarilG
Copy link
Contributor Author

BarilG commented Sep 22, 2014

Done.

</choose>
</if>
<else>
<text variable="title" prefix="«&#160;" suffix="&#160;»,"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as in the other styles -- guillemets with quote="true" please.

@adam3smith
Copy link
Member

Change requests (and some questions/suggestions that may or may not be right) in line. Please update and let us know when you're done.

@BarilG
Copy link
Contributor Author

BarilG commented Sep 23, 2014

Changes done.

@BarilG
Copy link
Contributor Author

BarilG commented Sep 23, 2014

Sorry, I missed some notes. I have to get thru it again and let you know when its's done.

@BarilG
Copy link
Contributor Author

BarilG commented Sep 23, 2014

File updated.

@BarilG
Copy link
Contributor Author

BarilG commented Sep 23, 2014

File updated.

@zuphilip
Copy link
Member

Replace "quote" with "quotes" as attribute (line 110, 130, 134). Make sure that your style is valid, you can check here: http://validator.citationstyles.org/

@BarilG
Copy link
Contributor Author

BarilG commented Sep 23, 2014

Replacement done.

adam3smith added a commit that referenced this pull request Sep 24, 2014
@adam3smith adam3smith merged commit 7b6cb41 into citation-style-language:master Sep 24, 2014
@adam3smith
Copy link
Member

Looks good, thanks.

@zuphilip - we don't enforce indenting on initial commits. Rintze periodically runs the reindent-reorder script that takes care of this and for initial commits, it doesn't really confuse the commit history. Getting indenting right is a nightmare for people who don't use either the visual editor or a real xml editor.

@rmzelle
Copy link
Member

rmzelle commented Sep 24, 2014

Made a tiny change to the title: 7b34b59

Thanks, @BarilG!

@adam3smith, @zuphilip, it would be nice if we could offer our users some way to properly indent their styles, but this would probably work best if we used the same lxml Python library I currently use for pretty printing all repository styles, and we would need some server space for that.

@BarilG
Copy link
Contributor Author

BarilG commented Sep 24, 2014

@rmzelle, @adam3smith, @zuphilip
Thank you very much for this collaborative work!

2014-09-24 8:51 GMT-04:00 Rintze M. Zelle notifications@github.com:

Made a tiny change to the title: 7b34b59
7b34b59

Thanks, @BarilG https://github.com/BarilG!

@adam3smith https://github.com/adam3smith, @zuphilip
https://github.com/zuphilip, it would be nice if we could offer our
users some way to properly indent their styles, but this would probably
work best if we used the same lxml http://lxml.de/ Python library I
currently use for pretty printing all repository styles, and we would need
some server space for that.


Reply to this email directly or view it on GitHub
#1120 (comment)
.

@BarilG BarilG deleted the patch-2 branch September 24, 2014 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants