Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network wireless profile workflow manager dev #140

Closed
wants to merge 90 commits into from
Closed

Network wireless profile workflow manager dev #140

wants to merge 90 commits into from

Conversation

md-rafeek
Copy link
Collaborator

@md-rafeek md-rafeek commented Mar 4, 2025 •
edited
Loading

Description

Temp pull request for sanity check

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

  • Tasks are idempotent (can be run multiple times without changing state)
  • Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
  • Playbooks are modular and reusable
  • Handlers are used for actions that need to run on change

Documentation

  • All options and parameters are documented clearly.
  • Examples are provided and tested.
  • Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

Kandarimegha and others added 30 commits February 1, 2025 13:03
@Kandarimegha
Add assurance issue settings workflow manager
bfb493b
@syed-khadeerahmed
new branch for application policy
fe465fb
@Kandarimegha
assurance healthscore workflow manager
47633ca
@Kandarimegha
remove commented code
08163af
@Kandarimegha
Assurance workflow manager
2f0487a
@md-rafeek
Pull req move to dev repo
9de091a
@md-rafeek
Network switch profile workflow manager
7c026e6
@md-rafeek
Network wireless profile workflow code completed
e447476
@md-rafeek
Network wireless profile workflow code completed
782e4ce
@md-rafeek
Path trace workflow minor code changes in comments
9b10725
@md-rafeek
Path trace UT cases added
8897468
@md-rafeek
Network switch profile with UT and IT added
5b0fdf0
@md-rafeek
Merge branch 'network_switch_profile_workflow_manager_dev' of github.…
cd48cd8 
…com:md-rafeek/madhan-dnacenter-ansible into network_wireless_profile_workflow_manager_dev
@syed-khadeerahmed
UT completed
0abaeb9
@md-rafeek
network_wireless_profile UT and IT added
a00da17
@Kandarimegha
removed extra log
0f27d40
@md-rafeek
network_switch_profile_workflow_manager completed
89d0f0f
@md-rafeek
network_switch_profile_workflow_manager completed
8ef72da
@md-rafeek
Merge branch 'network_switch_profile_workflow_manager_dev' of github.…
8502ee6 
…com:md-rafeek/madhan-dnacenter-ansible into network_wireless_profile_workflow_manager_dev
@md-rafeek
network_wireless_profile_workflow_manager minor fix
c49ecb8
@Kandarimegha
documentation update
c71f85d
@Kandarimegha
Delete playbooks/assurance_healthscore_settings_workflow_manager.yml
56135b7 
minor changes
@md-rafeek
Yaml Document changed for switch profile
89d7662
@md-rafeek
Path trace Addressed the review comments
fcaa165
@md-rafeek
Path trace workflow Addressed all code review comments
80497ee
@Kandarimegha
address review comments
ba97eb3
@Kandarimegha
Merge branch 'healthscore_workflow_manager' of https://github.com/Kan…
d87290e 
…darimegha/madhan-dnacenter-ansible into healthscore_workflow_manager
@md-rafeek
Switch profile changes in dnac move to network_profiles
af5345d
@md-rafeek
Network Switch profile Addressed code review Comments
49bd4bf
@md-rafeek
Merge branch 'network_switch_profile_workflow_manager_dev' of github.…
c1f022b 
…com:md-rafeek/madhan-dnacenter-ansible into network_wireless_profile_workflow_manager_dev
syed-khadeerahmed and others added 23 commits February 27, 2025 18:36
@syed-khadeerahmed
fixed review comments
cd355ff
@Kandarimegha
addressed review comment
a282702
@Kandarimegha
update example playbook
7dd20ee
@md-rafeek
Code reveiw comment addressed for path trace
ddb49e4
@md-rafeek
Code reveiw comment addressed for path trace
9b3aacf
@md-rafeek
Code reveiw comment addressed for path trace
bc10efc
@md-rafeek
Code reveiw comment addressed for path trace
7c409a3
@madhansansel
Merge pull request #1 from Kandarimegha/assurance_workflow_manager
28e932a 
Assurance issue settings workflow manager
@madhansansel
Merge pull request madhansansel#9 from cisco-en-programmability/main
f6f3a69 
Merge from mainline
@madhansansel
Merge pull request #4 from md-rafeek/pathtrace_workflow_manager_dev
0dbcf6c 
Path trace setting workflow manager
@madhansansel
Merge pull request #3 from Kandarimegha/healthscore_workflow_manager
4e47e20 
assurance healthscore settings workflow manager
@Kandarimegha
Modified code for severity validation
1645c21
@Kandarimegha
Merge branch 'main' of https://github.com/cisco-en-programmability/ca…
3fb9bb6 
…talyst-center-ansible-dev into assurance_workflow_manager
@Kandarimegha
update severity value in exmple
de35356
@Kandarimegha
minor modification
97fe721
@madhansansel
Merge pull request madhansansel#10 from Kandarimegha/assurance_workfl…
5a5d952 
…ow_manager

Updated severity field to support both integer and string values with corresponding choices
@syed-khadeerahmed
fixed review comments
bfce56f
@madhansansel
Merge pull request #2 from syed-khadeerahmed/application_policy_workf…
c50830c 
…low_manager

 application policy workflow manager
@md-rafeek
Merge branch 'main' of https://github.com/cisco-en-programmability/ca…
d096fa0 
…talyst-center-ansible-dev into network_switch_profile_workflow_manager_dev
@md-rafeek
Merge branch 'network_switch_profile_workflow_manager_dev' of github.…
f7e48ed 
…com:md-rafeek/madhan-dnacenter-ansible into network_wireless_profile_workflow_manager_dev
@madhansansel
Merge pull request madhansansel#11 from cisco-en-programmability/main
ae7bdd6 
Merge from Mainline
@madhansansel
Merge pull request madhansansel#12 from cisco-en-programmability/main
8ed0057 
Update ansible-lint.yml
@md-rafeek
Network wireless profile code refactor and added functionality
6d4e16d
@md-rafeek md-rafeek requested a review from madhansansel as a code owner March 4, 2025 14:58
@md-rafeek md-rafeek closed this Mar 4, 2025
@md-rafeek
Copy link
Collaborator Author

added the sanity in dev branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhansansel madhansansel Awaiting requested review from madhansansel madhansansel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@md-rafeek @Kandarimegha @syed-khadeerahmed @madhansansel