Modernize the build step in the build workflow
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonnnj
added
the
improvement
jsf9k
approved these changes
Mar 14, 2022
dav3r
approved these changes
Mar 14, 2022
1 task
mcdonnnj
force-pushed
the
improvement/update_build_process
branch
from
bc1adda
to
96f816e
Compare
Add dist/ to the .gitignore file to better support local building.
Modernize the build process by using the build package instead of the now deprecated setup.py install method. Remove installing the package requirements as it is unnecessary for this build process. Upgrade the setuptools package as part of the initial dependency installation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the
buildstep of thebuildworkflow to use a more modern process to build the bdist/sdist for a Python package. It also addsdistto the.gitignorefile to more cleanly support local building.💭 Motivation and context
Building Python packages with the
setup.py installmethod has been deprecated for a while now so we should update our package building process to align with PyPa's current process.🧪 Testing
Automated tests pass. I verified that the artifact contains both a bdist (wheel) and sdist.
✅ Pre-approval checklist