Disable fail-fast for GitHub Actions Jobs with a Matrix Strategy
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override the default by setting `fail-fast` to `false` for the test and build jobs in our GHA build workflow. This ensure that all matrix jobs run regardless of a failure.
mcdonnnj
added
the
improvement
jsf9k
approved these changes
Oct 29, 2021
felddy
approved these changes
Oct 29, 2021
mcdonnnj
deleted the
improvement/disable_fail-fast_for_test_and_build_jobs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pr sets
fail-fast: falsefor any GitHub Actions job that employs a matrix strategy.💭 Motivation and context
This ensures that all generated runs for the matrix strategy run to completion regardless of the finishing state of other runs.
🧪 Testing
Automated tests pass. The same setting is used for our Ansible role
testjob.✅ Checklist