Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull in Upstream Updates #39

Merged
merged 7 commits into from
Mar 31, 2020
Merged

Pull in Upstream Updates #39

merged 7 commits into from
Mar 31, 2020

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This PR pulls in the changes in cisagov/skeleton-generic#40 (and cisagov/skeleton-generic#39 and cisagov/skeleton-generic#38).

💭 Motivation and Context

Keep it up to date!

🧪 Testing

pre-commit runs without issue.

📷 Screenshots (if appropriate)

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcdonnnj
Change the cache paths from hardcoded values in their appropriate blo…
478f168 
…cks to environment variables declared before the job block.
@mcdonnnj
Merge pull request #38 from cisagov/change_cache_paths_to_env_variables
241484a 
Change Cache Paths to Environment Variables
@mcdonnnj
Add a rule for markdownlint to allow multiple headers with the same n…
d791334 
…ame as long

as they are not nested in the same heading group.
@mcdonnnj
Merge pull request #39 from cisagov/add_mdl_rule_for_MD024
f5fd431 
Add markdownlint Configuration Option for MD024
@mcdonnnj
Fixed broken hook id for pre-commit-terraform:
61790a9 
  terraform_validate_no_variables was changed to terraform_validate in the
  following commit:
  antonbabenko/pre-commit-terraform@35e0356.
Ran pre-commit autoupdate.
@mcdonnnj
Merge pull request #40 from cisagov/improvements/update_pre-commit
757a861 
Update pre-commit Hooks and Fix Broken Hook ID
@mcdonnnj
Merge branch 'develop' of github.com:cisagov/skeleton-generic into im…
39abc2c 
…provements/upstream_updates
@mcdonnnj mcdonnnj requested review from dav3r, felddy, jsf9k and a team as code owners March 31, 2020 20:03
@mcdonnnj mcdonnnj self-assigned this Mar 31, 2020
dav3r
dav3r approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐍

jsf9k
jsf9k approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hot 💩!

@mcdonnnj mcdonnnj merged commit 61d3644 into develop Mar 31, 2020
@mcdonnnj mcdonnnj deleted the improvements/upstream_updates branch March 31, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
None yet
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r