Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to verify TRAVIS_TAG agrees with project version during release #14

Merged
merged 4 commits into from
Jun 20, 2019
Merged

Add test to verify TRAVIS_TAG agrees with project version during release #14

merged 4 commits into from
Jun 20, 2019

Conversation

felddy
Copy link
Member

@felddy felddy commented Jun 20, 2019

No description provided.

@felddy felddy requested a review from a team June 20, 2019 15:33
@felddy felddy self-assigned this Jun 20, 2019
dav3r
dav3r approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please consider my comments.

tests/test_example.py Outdated Show resolved Hide resolved
tests/test_example.py Outdated Show resolved Hide resolved
jsf9k
jsf9k requested changes Jun 20, 2019
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a question. I can re-review once it is answered.

tests/test_example.py Outdated Show resolved Hide resolved
@felddy felddy requested a review from jsf9k June 20, 2019 16:17
jsf9k
jsf9k approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@felddy felddy merged commit 5234c03 into develop Jun 20, 2019
@felddy felddy deleted the improvement/travis_version_test branch June 20, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

Assignees

@felddy felddy

Labels
None yet
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felddy @jsf9k @dav3r