Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a diagnostics job to the CodeQL workflow #125

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add a diagnostics job to the CodeQL workflow #125

merged 1 commit into from
Dec 19, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 11, 2023

🗣 Description

This pull request adds a diagnostics job to the CodeQL workflow.

💭 Motivation and context

It's good to agree everywhere with the changes we made to the build.yml workflow in cisagov/skeleton-generic#144.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k
Add a diagnostics job to the CodeQL workflow
0541200 
It's good to agree everywhere with the changes we made to the
build.yml workflow in cisagov/skeleton-generic#144.
@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation github-actions Pull requests that update GitHub Actions code kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release security This issue or pull request addresses a security issue labels Oct 11, 2023
@jsf9k jsf9k marked this pull request as ready for review October 11, 2023 20:34
@jsf9k jsf9k requested a review from a team October 11, 2023 20:34
dav3r
dav3r approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcdonnnj mcdonnnj added this pull request to the merge queue Dec 19, 2023
@mcdonnnj mcdonnnj removed this pull request from the merge queue due to the queue being cleared Dec 19, 2023
@mcdonnnj mcdonnnj added this pull request to the merge queue Dec 19, 2023
@mcdonnnj mcdonnnj removed this pull request from the merge queue due to the queue being cleared Dec 19, 2023
@mcdonnnj mcdonnnj added this pull request to the merge queue Dec 19, 2023
Merged via the queue into develop with commit 593f588 Dec 19, 2023
54 checks passed
@mcdonnnj mcdonnnj deleted the improvement/add-diagnostics-job-for-codeql-workflow branch December 19, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
github-actions Pull requests that update GitHub Actions code hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release security This issue or pull request addresses a security issue
Projects
Next Kraken
Status: Done
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @dv4harr10 @mcdonnnj