Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a GitHub Actions job to test built wheels #116

Merged
merged 2 commits into from
Jan 7, 2023
Merged

Add a GitHub Actions job to test built wheels #116

merged 2 commits into from
Jan 7, 2023

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Jan 5, 2023 •
edited
Loading

🗣 Description

This pull request adds a test_build job to the GitHub Actions build workflow that will test the wheels built in the build job of the workflow.

💭 Motivation and context

We should verify that the wheels built pass tests to ensure that the Python package works as intended if distributed.

🧪 Testing

Automated tests should pass once #110 and #114 are merged.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jan 5, 2023
@mcdonnnj mcdonnnj self-assigned this Jan 5, 2023
@mcdonnnj mcdonnnj requested a review from dav3r as a code owner January 5, 2023 20:12
dav3r
dav3r approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@mcdonnnj mcdonnnj added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jan 5, 2023
@mcdonnnj
Add a GitHub Actions job to test wheels
034cef8 
This job will test thw wheels created during the `build` job to ensure
the distribution artifact also passes tests.
@mcdonnnj
Prefer block-style to flow-style in GitHub Actions job needs
63f4a73
@mcdonnnj mcdonnnj force-pushed the improvement/test_wheels_built_in_github_actions branch from 0725abe to 63f4a73 Compare January 7, 2023 20:28
@mcdonnnj mcdonnnj merged commit cbc0157 into develop Jan 7, 2023
@mcdonnnj mcdonnnj deleted the improvement/test_wheels_built_in_github_actions branch January 7, 2023 20:33
@mcdonnnj mcdonnnj mentioned this pull request Jan 11, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r