Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a diagnostics job for the label syncing workflow #150

Merged

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Sep 13, 2023

Also add a runner hardening task to the labeler job.

🗣 Description

This pull request adds a diagnostics job to the sync-labels.yml workflow. It also adds a runner hardening task to the labeler job in that workflow.

💭 Motivation and context

This agrees with the changes we made to the build.yml workflow in #144. I believe such changes should be made globally to all of our workflows, with the goal of eventually changing the runner hardening task to enforce (as opposed to audit) the hardening rules.

🧪 Testing

All automated tests pass. I examined the results of the workflow runs with my ocular orbs.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

Also add a runner hardening task to the labeler job.
@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use github-actions Pull requests that update GitHub Actions code labels Sep 13, 2023
@jsf9k jsf9k self-assigned this Sep 13, 2023
@jsf9k jsf9k marked this pull request as ready for review September 13, 2023 16:58
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and I was having a similar thought 👍

@jsf9k jsf9k added kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release security This issue or pull request addresses a security issue labels Sep 13, 2023
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@mcdonnnj mcdonnnj added this pull request to the merge queue Mar 6, 2024
Merged via the queue into develop with commit d0d8783 Mar 6, 2024
6 checks passed
@mcdonnnj mcdonnnj deleted the improvement/add-diagnostics-to-label-sync-workflow branch March 6, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release security This issue or pull request addresses a security issue
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants