Consider moving contents of `.flake8` and `.isort.cfg` to a `pyproject.toml` file

[jsf9k]

💡 Summary

Consider moving the contents of .flake8 and .isort.cfg to a pyproject.toml file, in [tool.flake8] and [tool.isort] sections, respectively.

Motivation and context

This would be useful because it would simplify cisagov/skeleton-python-library by consolidating all the Python tool configurations in a single file (the pyproject.toml file).

Implementation notes

This would require the addition of the Python library flake8-pyproject as a dependency.

[jsf9k]

@mcdonnnj and @dav3r - Please let me know what you think. See also cisagov/skeleton-python-library#164.

[dav3r]

Sounds like a good change to me. If the only downside is adding flake8-pyproject as a dependency, I'm on board with that.

[mcdonnnj]

A bit too late to this party that I missed, but I would have voted in the negative for this change. A pyproject.toml file signifies that a directory contains a Python project. That is not the case at this level and misrepresents projects based directly from this skeleton (except for cisagov/skeleton-python-library). The advantages of storing the configurations in a pyproject.toml file could have been enacted downstream in cisagov/skeleton-python-library which is where it is appropriate to have a pyproject.toml file.

[jsf9k]

Noted, but I think a pyproject.toml without a [project] section is a pretty clear indication that the file is only being used for Python tool configuration. Do you have a link to any documentation that says this use of the pyproject.toml file is a perversion?

Also, having to merge changes to individual config files from cisagov/skeleton-generic into the pyproject.toml file in cisagov/skeleton-python-library would also lead to a maintenance problem, since we would sometimes overlook upstream changes. For this reason, if we choose not to move ahead with #235 then I think we should just keep the individual configuration files everywhere. At my age, "one less thing to remember" draws a lot of water.