Switch to using ansible-role-assessment-tool and ansible-role-burp-suite-pro instead of the monolithic ansible-role-kali #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary when using ansible-role-assessment-tool multiple times.
This code now has to pull from ansible-role-burp-suite-pro's remote state instead of ansible-role-kali's remote state.
…s config option The config option is not being set, possibly because the JSON argument to --extra-vars is not being interpreted correctly and is interpreting all vars as strings.
This is necessary to define the appropriate bucket to use when building staging and production AMIs.
This is necessary since the issue has been transferred to this repo from another one.
jsf9k
added
the
improvement
This is done because that playbook will reinstall Python 2, so it should go last.
dav3r
approved these changes
Dec 31, 2020
Comment on lines
+273
to
+274
| # The misspelling here is intentional. See | ||
| # https://github.com/SimplySecurity/SimplyEmail/blob/master/setup/requirments.txt. |
There was a problem hiding this comment.
SimplySecurity/SimplyEmail#49 if that ever got merged (probably very unlikely), we would need to undo the customization.
Also use cisagov/ansible-role-assessment-tool to install the Cobalt Strike addons.
This is done because ysoserial requires a Java implementation be installed as well.
…al tasks into their own files Also update the version of the ansible-lint pre-commit hook. The older version incorrectly flags an error when using ansible.builtin.import_tasks.
jsf9k
force-pushed
the
improvement/monolithic-kali-role-is-no-more
branch
from
5def692 to
87361d7
Compare
mcdonnnj
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request switches to using cisagov/ansible-role-assessment-tool and cisagov/ansible-role-burp-suite-pro instead of the monolithic cisagov/ansible-role-kali.
As a result of functionality added to cisagov/ansible-role-assessment-tool when splitting it out from cisagov/ansible-role-kali, this also adds Python virtual environments for the Python tools installed from source. See cisagov/ansible-role-assessment-tool#1 for more details.
💭 Motivation and Context
cisagov/ansible-role-kali had become too large and monolithic. It was doing too many things, and it was becoming difficult to add functionality. It is better for Ansible roles to serve a single purpose, so I never liked having such a monster role. It made sense to split it up before adding support for Python virtual environments.
🧪 Testing
I successfully built and deployed a new Kali AMI to our staging COOL environment.
✅ Checklist