-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create cyhy logging module #1
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Pull Request Test Coverage Report for Build 11446008098Details
💛 - Coveralls |
- Add a better summary - Add example usage - Add example output
- Removing undocumented pins (setuptools) - Removing unneeded pins (coveralls)
- Add developer name and email - Upgrade development status to production / stable Co-authored-by: dav3r <david.redmin@trio.dhs.gov> Update setup.py Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - strong work! 🦾 💼
🗣 Description
This PR introduces initial logging configuration for the
cyhy-logging
repository, including setting up a basic logging infrastructure that aligns with our current standards.This configuration aims to streamline log collection and standardize logging across different components of CyHy.
💭 Motivation and context
The CyHy system requires consistent and centralized logging to effectively monitor activities, identify issues, and analyze the health of services.
This change establishes a consistent logging standard and integrates the logging service into the codebase, ensuring uniformity in logging practices across services. The approach was to implement a well-tested configuration using Python's
logging
module.🧪 Testing
The changes were tested using unit tests to ensure that logging output follows the desired format and level settings. Additionally, the service was run in a test environment, and logs were inspected for proper content and format.
Tests were executed in a local Docker environment running Python 3.12. Logging was validated in both
stdout
and file outputs. Verified that different log levels were correctly captured.✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist