Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cyhy logging module #1

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Create cyhy logging module #1

merged 9 commits into from
Oct 21, 2024

Conversation

felddy
Copy link
Member

@felddy felddy commented Sep 24, 2024

🗣 Description

This PR introduces initial logging configuration for the cyhy-logging repository, including setting up a basic logging infrastructure that aligns with our current standards.

This configuration aims to streamline log collection and standardize logging across different components of CyHy.

💭 Motivation and context

The CyHy system requires consistent and centralized logging to effectively monitor activities, identify issues, and analyze the health of services.

This change establishes a consistent logging standard and integrates the logging service into the codebase, ensuring uniformity in logging practices across services. The approach was to implement a well-tested configuration using Python's logging module.

🧪 Testing

The changes were tested using unit tests to ensure that logging output follows the desired format and level settings. Additionally, the service was run in a test environment, and logs were inspected for proper content and format.

Tests were executed in a local Docker environment running Python 3.12. Logging was validated in both stdout and file outputs. Verified that different log levels were correctly captured.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@felddy felddy self-assigned this Sep 24, 2024
@felddy felddy added documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add new or improve existing functionality labels Sep 24, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@felddy felddy marked this pull request as ready for review October 21, 2024 16:56
@coveralls
Copy link

coveralls commented Oct 21, 2024

Pull Request Test Coverage Report for Build 11446008098

Details

  • 46 of 46 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11191662636: 0.0%
Covered Lines: 46
Relevant Lines: 46

💛 - Coveralls

- Add a better summary
- Add example usage
- Add example output
- Removing undocumented pins (setuptools)
- Removing unneeded pins (coveralls)
setup.py Outdated Show resolved Hide resolved
- Add developer name and email
- Upgrade development status to production / stable

Co-authored-by: dav3r <david.redmin@trio.dhs.gov>

Update setup.py

Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - strong work! 🦾 💼

@felddy felddy merged commit 39fa6ab into develop Oct 21, 2024
17 checks passed
@felddy felddy deleted the first-commits branch October 21, 2024 19:05
@felddy felddy added the hacktoberfest-accepted Marks a pull request as counting toward Hacktoberfest participation. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue or pull request improves or adds to documentation hacktoberfest-accepted Marks a pull request as counting toward Hacktoberfest participation. improvement This issue or pull request will add new or improve existing functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants