Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ CONFLICT! Lineage pull request for: skeleton #53

Merged
merged 48 commits into from
Jun 17, 2022

Conversation

cisagovbot
Copy link

@cisagovbot cisagovbot commented Jun 13, 2022

Lineage Pull Request: CONFLICT

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-docker.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

The lineage/skeleton branch has one or more unresolved merge conflicts
that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone git@github.com:cisagov/certboto-docker.git certboto-docker
    cd certboto-docker
    git remote add skeleton https://github.com/cisagov/skeleton-docker.git
    git remote set-url --push skeleton no_push
    git switch develop
    git checkout -b lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and
    possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the
    branch, commit, and push your changes:

    git add README.md docker-compose.yml tests/container_test.py 
    git commit
    git push --force --set-upstream origin lineage/skeleton

    Note that you may append to the default merge commit message
    that git creates for you, but please do not delete the existing
    content
    . It provides useful information about the merge that is
    being performed.

  5. Wait for all the automated tests to pass.

  6. Check the "Everything is cool" checkbox below:

    • ✌️ The conflicts in this pull request have been resolved.
  7. Mark this draft pull request "Ready for review".


Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

mcdonnnj and others added 30 commits February 23, 2022 20:11
Update pre-commit hooks using `pre-commit autoupdate`.
This comment explains that the configuration may have commented out
ignore directives that should be uncommented in downstream projects.
yamllint does not like it when you comment out pieces of dictionaries
in lists. Upcoming additions to the Dependabot configuration will run
afoul of this so we are updating the yamllint configuration.
…_yamllint_configurations

Add boilerplate for upcoming Dependabot configuration changes
Given the inconsistent behavior of underscores used within words for
style we should prefer asterisks now that these rules are available.
…configuration

Use new `markdownlint` rules for emphasis- and strong-styles
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 2 to 3.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Update pre-commit hooks using `pre-commit autoupdate`. The `ansible-lint` hook
is intentionally held back due to issues with upgrading to v6.
This adds commented out ignore directives for the following GitHub
Actions:

- action/cache
- action/checkout
- action/setup-python

These should be uncommented downstream to ensure that updates to these
dependencies are pushed from pull requests made in the skeleton.
…s/setup-python-3

Bump actions/setup-python from 2 to 3
…s/checkout-3

Bump actions/checkout from 2 to 3
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2...v3)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…es_for_github_actions

Add Dependabot ignore directives
Use Python 3.10 for the `lint` job in GitHub Actions
Add hooks to validate GitHub Actions and GitHub Action workflows. These
are validated using JSON Schemas.
…re-commit_hooks

Add `pre-commit` hooks to validate GitHub Actions content
Uncomment the `github-actions` Dependabot ignore directives because
those dependencies are managed by cisagov/skeleton-generic upstream.
@cisagovbot cisagovbot added the upstream update This issue or pull request pulls in upstream updates label Jun 13, 2022
Enable the new ignore directives for dependencies managed by
cisagov/skeleton-docker.
These variables are from the skeleton and are not used in this
configuration.
@mcdonnnj mcdonnnj closed this Jun 13, 2022
@mcdonnnj mcdonnnj reopened this Jun 13, 2022
@mcdonnnj mcdonnnj marked this pull request as ready for review June 13, 2022 16:14
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcdonnnj mcdonnnj merged commit c0f83a3 into develop Jun 17, 2022
@mcdonnnj mcdonnnj deleted the lineage/skeleton branch June 17, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream update This issue or pull request pulls in upstream updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants