Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PIM for Groups to AAD baseline instructions for 7.6 through 7.9 #926

Conversation

tkol2022
Copy link
Collaborator

@tkol2022 tkol2022 commented Feb 21, 2024

🗣 Description

Modify the AAD baseline document instructions for policies 7.6 through 7.9 to incorporate PIM for Groups. There is a coding issue that is currently in the works that aligns with these changes as well.

Closes #920

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@tkol2022 tkol2022 added the baseline-document Issues relating to the text in the baseline documents themselves label Feb 21, 2024
@tkol2022 tkol2022 added this to the Glacier milestone Feb 21, 2024
@tkol2022 tkol2022 self-assigned this Feb 21, 2024
Copy link
Collaborator

@gdasher gdasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on offline discussion, I'm fine with these changes.

Copy link
Collaborator

@mitchelbaker-cisa mitchelbaker-cisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went into admin console and checked the updated steps.

@tkol2022
Copy link
Collaborator Author

@nanda-katikaneni ready for merge

@nanda-katikaneni nanda-katikaneni merged commit f6bdb31 into main Mar 4, 2024
14 of 16 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 920-modify-aad-baseline-instructions-76-through-79-to-cover-pim-for-groups branch March 4, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
baseline-document Issues relating to the text in the baseline documents themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify AAD baseline instructions 7.6 through 7.9 to cover PIM for Groups
4 participants