Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YAML and PowerShell linter warnings #809

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

schrolla
Copy link
Collaborator

@schrolla schrolla commented Jan 17, 2024

🗣 Description

The updates in this PR resolve several warnings from existing linting checks which includes:

  • Adding a PSScriptAnalyzer configuration file to suppress some warnings during checks
  • Updating the PowerShell linter workflow to use the new configuration settings
  • Resolving YAML trailing whitespace and indentation warnings
  • Fixes path to Pester tests for markdown checks workflow

💭 Motivation and context

This change resolves automated testing check failures. Resolving the issue ensures a clean passing baseline for the current development branch.

Closes #808

🧪 Testing

Since these updates affect the automated checks. Testing is done by reviewing the Lint Check for YAML and Lint Check for PowerShell check results. Also added changes to fix silent fail of 'Markdown Check' workflow. Results should be green and show that all configured tests were run successfully.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Rebase against parent branch if necessary

✅ Post-merge checklist

  • Ensure that automated checks on parent branch pass after the merge

* Fix YAML AAD warnings
* Add PSScriptAnalyzer settings
* Add PSScriptAnalyzer settings toPS linter workflow
@schrolla schrolla added the bug This issue or pull request addresses broken functionality label Jan 17, 2024
@schrolla schrolla added this to the Flipper milestone Jan 17, 2024
@schrolla schrolla self-assigned this Jan 17, 2024
@schrolla schrolla linked an issue Jan 17, 2024 that may be closed by this pull request
@schrolla schrolla changed the base branch from main to flipper January 17, 2024 20:28
Copy link
Collaborator

@james-garriss james-garriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all look good to me.

@schrolla schrolla marked this pull request as ready for review January 17, 2024 20:36
Copy link
Collaborator

@nanda-katikaneni nanda-katikaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

@nanda-katikaneni nanda-katikaneni merged commit d7cdac4 into flipper Jan 17, 2024
6 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 808-fix-yaml-and-powershell-test-failures branch January 17, 2024 21:45
schrolla added a commit that referenced this pull request Jan 19, 2024
* Fix linter warnings
* Fix YAML AAD warnings
* Add PSScriptAnalyzer settings
* Add PSScriptAnalyzer settings toPS linter workflow

* Fix pester test path in markdown check workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix YAML and PowerShell test failures
3 participants