-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate CISA review feedback into aad baseline #671
Merged
nanda-katikaneni
merged 20 commits into
main
from
532-integrate-cisa-review-feedback-into-aad-baseline
Nov 20, 2023
Merged
Integrate CISA review feedback into aad baseline #671
nanda-katikaneni
merged 20 commits into
main
from
532-integrate-cisa-review-feedback-into-aad-baseline
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkol2022
added
the
baseline-document
Issues relating to the text in the baseline documents themselves
label
Nov 14, 2023
3 tasks
nanda-katikaneni
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to most part - commented in-line about a few inconsistencies/mismatches. One comment about Word document: the table of contents need an update, it currently has a weird format.
Will read through the full doc one more time for any additional comments.
mheller93766
suggested changes
Nov 15, 2023
…ghout the document Co-authored-by: Shanti Satyapal <78565245+ssatyapal123@users.noreply.github.com>
…https://github.com/cisagov/ScubaGear into 532-integrate-cisa-review-feedback-into-aad-baseline
nanda-katikaneni
approved these changes
Nov 17, 2023
mheller93766
approved these changes
Nov 17, 2023
ssatyapal123
approved these changes
Nov 17, 2023
nanda-katikaneni
deleted the
532-integrate-cisa-review-feedback-into-aad-baseline
branch
November 20, 2023 20:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This update includes the following changes to the M365 AAD security configuration baseline:
This update does NOT include any materially significant changes to the number of or content in policy items in the baseline itself that would require a change in settings to align with the baseline recommendations.
💭 Motivation and context
The updates included further refine and improve the overall readability and clarity of the baseline document. The result should be a baseline that is easier to interpret and use as a reference for M365 tenant administrators.
Closes #532
🧪 Testing
Compare the separately provided Word version with track changes of the AAD baseline document with the changes in the markdown in this branch. Accepted/modified suggested changes as appropriate and mirrored in markdown, rejected and additional changes commented in Word and sync'd to markdown as needed.
Manual review of markdown and ensure that the automated markdown test on the PR passes.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist