Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate CISA review feedback into aad baseline #671

Merged

Conversation

tkol2022
Copy link
Collaborator

🗣 Description

This update includes the following changes to the M365 AAD security configuration baseline:

  • Changes to improve overall consistency of format and language throughout
  • Grammar and spelling fixes
  • Language and verbiage updates for increased reader clarity

This update does NOT include any materially significant changes to the number of or content in policy items in the baseline itself that would require a change in settings to align with the baseline recommendations.

💭 Motivation and context

The updates included further refine and improve the overall readability and clarity of the baseline document. The result should be a baseline that is easier to interpret and use as a reference for M365 tenant administrators.

Closes #532

🧪 Testing

Compare the separately provided Word version with track changes of the AAD baseline document with the changes in the markdown in this branch. Accepted/modified suggested changes as appropriate and mirrored in markdown, rejected and additional changes commented in Word and sync'd to markdown as needed.

Manual review of markdown and ensure that the automated markdown test on the PR passes.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Rebase the branch against the parent branch prior to merge as needed.
  • All CISA feedback has been reviewed and adjudicated successfully

✅ Post-merge checklist

  • Confirm that the parent branch passes all tests after the merge

@tkol2022 tkol2022 added the baseline-document Issues relating to the text in the baseline documents themselves label Nov 14, 2023
@tkol2022 tkol2022 added this to the Emerald milestone Nov 14, 2023
@tkol2022 tkol2022 self-assigned this Nov 14, 2023
@tkol2022 tkol2022 linked an issue Nov 14, 2023 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@nanda-katikaneni nanda-katikaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to most part - commented in-line about a few inconsistencies/mismatches. One comment about Word document: the table of contents need an update, it currently has a weird format.

Will read through the full doc one more time for any additional comments.

baselines/aad.md Outdated Show resolved Hide resolved
baselines/aad.md Show resolved Hide resolved
baselines/aad.md Outdated Show resolved Hide resolved
baselines/aad.md Show resolved Hide resolved
baselines/aad.md Outdated Show resolved Hide resolved
baselines/aad.md Outdated Show resolved Hide resolved
baselines/aad.md Outdated Show resolved Hide resolved
tkol2022 and others added 2 commits November 15, 2023 17:10
…ghout the document

Co-authored-by: Shanti Satyapal <78565245+ssatyapal123@users.noreply.github.com>
baselines/aad.md Outdated Show resolved Hide resolved
@nanda-katikaneni nanda-katikaneni merged commit dd05a0c into main Nov 20, 2023
12 checks passed
@nanda-katikaneni nanda-katikaneni deleted the 532-integrate-cisa-review-feedback-into-aad-baseline branch November 20, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
baseline-document Issues relating to the text in the baseline documents themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate CISA review feedback into AAD baseline
5 participants