Stream Cirrus CI webhook events to DataDog #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
Jul 11, 2023
internal/command/datadog/datadog.go
Outdated
Comment on lines
123
to
126
| evt := &statsd.Event{ | ||
| Title: fmt.Sprintf("Webhook event of type %s", eventType), | ||
| Text: string(body), | ||
| } |
There was a problem hiding this comment.
Does it support some tags? To annotate it with repository name, user id, etc. Events should be useful and not just some raw dump of webhooks.
There was a problem hiding this comment.
It seems that DataDog actually treats the Text as JSON and allows filtering by it's fields:
I've added some tags in 648ecaf anyway.
fkorotkov
reviewed
Jul 12, 2023
fkorotkov
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resulting event looks in DataDog like this:
Resolves #1.