Skip to content

Fix MicroPython showing busy forever #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

Fix MicroPython showing busy forever #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions js/workflows/usb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,6 @@ class USBWorkflow extends Workflow {
device = await navigator.serial.requestPort();
console.log(device);
}

// TODO: Make it more obvious to user that something happened for smaller screens
// Perhaps providing checkmarks by adding a css class when a step is complete would be helpful
// This would help with other workflows as well
} else {
console.log('Requesting any serial device...');
try {
Expand Down Expand Up @@ -171,7 +167,7 @@ class USBWorkflow extends Workflow {
btnSelectHostFolder.disabled = true;
let serialConnect = async (event) => {
try {
await this.showBusy(this.connectToSerial());
await this.connectToSerial();
} catch (e) {
//console.log(e);
//alert(e.message);
Expand Down Expand Up @@ -291,7 +287,7 @@ class USBWorkflow extends Workflow {

// At this point we should see if we should init the file client and check if have a saved dir handle
let fileops = new FileOps(this.repl, false);
if (await fileops.isReadOnly()) {
if (await this.showBusy(fileops.isReadOnly())) {
// UID Only needed for matching the CIRCUITPY drive with the Serial Terminal
await this.showBusy(this._getDeviceUid());
let modal = this.connectDialog.getModal();
Expand Down