Updating querpy #2
Conversation
Ft port to python 3
added create table function
|
Just a quick bump on this? Any chance for these changes to be accepted? because I have more waiting... Either way is fine.. |
|
Hello, as I mentioned in my commit @dmahone1 found a bug in the codebase which caused any variable name with 'OR' in it.. like 'REQUESTOR' or 'ORIGIN' to be caught by the regex that is looking for SQL 'OR' clauses.. and it replaces them with a newline.. This is serious bug, and without this pull request accepted, it is probably dangerous to rely on this code.. I think if you wanted you could extract the bug fix if you look at the commit that mentions @dmahone1 and make that change without accepting the rest of the pull request. -ft |
|
We continue to slowly improve the functioning of ftrotter/querpy feel free to look there for updated code. But if I had really understood SQlAlchemy when I was just starting out. I would have used that instead. |
Hey,
I really need something that works just like querpy. But unfortunately, the current querpy does not support python 3, and it does not support "CREATE TABLE dbname.tablename AS" or "LIMIT 10, 100" statements. Which use frequently.
I also found the code (especially the regexes) confusing and so I spent some time documenting the code...
I will be adding other features soon, like the ability to change CREATE TABLE into an INSERT INTO syntax, and possibly some more advanced WHERE logic.
If you are not interested in handling pull requests for an old project, let me know and I will fork and rename the project. In any case, thank you very much for a great starting point!
Regards,
-ft