Skip to content

Adds compatibility support for MGSFPSUnlock#15

Merged
cipherxof merged 4 commits intocipherxof:mainfrom
ShizCalev:fpsunlock
Jul 25, 2025
Merged

Adds compatibility support for MGSFPSUnlock#15
cipherxof merged 4 commits intocipherxof:mainfrom
ShizCalev:fpsunlock

Conversation

@ShizCalev
Copy link
Copy Markdown
Contributor

crouchwalking speed is presently tied to framerate, and the speed multipliers you set in the config file get doubled/tripled/ect when using mgsfpsunlock.

this makes the speed multipliers always consistent by parsing MGSFPSUnlock's ini for the target fps & adjusting accordingly.

@cipherxof
Copy link
Copy Markdown
Owner

cipherxof commented Apr 8, 2025

This is a bit of a messy implementation. We shouldn't be relying on the configuration file of a separate mod to adjust the walking speed. Instead, we should determine what the current fps target is by looking at the actor wait value. Using a pattern scan to look up the value is a bit more prone to breaking, but I suppose we can use a fallback if the value can't be found.

@ShizCalev
Copy link
Copy Markdown
Contributor Author

Opps, haven't checked my notifications in a bit!

Implemented the relative offset lookup for actorWaitValue you added in cipherxof/MGSFPSUnlock#22 & kept the FPSUnlock config read in as a fallback in case the patternscan fails - let me know if you just want that part scrapped all together though!

@cipherxof
Copy link
Copy Markdown
Owner

Looks good, although I would remove the integration with FPS unlock plugin completely. The actor wait value should be good enough, and if it can't be found just default to the original value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants