fix(eql-mapper): resolution of CTE tables #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolutions of CTE tables would only succeed from the main statement of a `WITH` but not sub-statements of that statement. The fix was to not create parentless scopes on entry to Statement nodes - instead create a new scope pointing to the parent scope.
auxesis
approved these changes
Jul 16, 2025
Contributor
auxesis
left a comment
auxesis
left a comment
There was a problem hiding this comment.
LGTM, thanks @freshtonic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolutions of CTE tables would only succeed from the main statement of a
WITHbut not sub-statements of that statement.The fix was to not create parentless scopes on entry to Statement nodes - instead create a new scope pointing to the parent scope.
Acknowledgment
By submitting this pull request, I confirm that CipherStash can use, modify, copy, and redistribute this contribution, under the terms of CipherStash's choice.