SET command to disable mapping #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyhede
force-pushed
the
fix/prevent-unsupported-sql-syntax-from-breaking-migrations
branch
from
25c7ef7 to
5d3569a
Compare
When the proxy sees the following command from a client: ```sql SET LOCAL UNSAFE_SKIP_MAPPING_NEXT_STATEMENT = t; ``` Parsing & mapping of the next statement ONLY will be skipped. This is useful for working around `sqlparser` SQL grammar coverage issues for database migrations in particular. This command is not yet documented. It's possible that its full implications may not be fully understood re: security and therefore it's probably best to reveal its existence to customers on an as-needed basis. We should also consider a Proxy configuration option for completely disabling this command. NOT YET IMPLEMENTED: - Setting this variable should also disable decryption of any results returned from the query, closing off a potential exploit. - Integration test
tobyhede
force-pushed
the
fix/prevent-unsupported-sql-syntax-from-breaking-migrations
branch
3 times, most recently
from
d13b1f9 to
031cc69
Compare
tobyhede
changed the title
tobyhede
changed the title
tobyhede
force-pushed
the
fix/prevent-unsupported-sql-syntax-from-breaking-migrations
branch
from
031cc69 to
b5a6b5f
Compare
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com> Signed-off-by: Toby Hede <tobyhede@info-architects.net>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com> Signed-off-by: Toby Hede <tobyhede@info-architects.net>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com> Signed-off-by: Toby Hede <tobyhede@info-architects.net>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com> Signed-off-by: Toby Hede <tobyhede@info-architects.net>
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com> Signed-off-by: Toby Hede <tobyhede@info-architects.net>
tobyhede
approved these changes
Jun 25, 2025
- make title active - explain context of encrypted mapping - remove definite article, to remove diminuitive - line per sentence, to improve maintainability - explain that the section refers to mapping behaviour
auxesis
force-pushed
the
fix/prevent-unsupported-sql-syntax-from-breaking-migrations
branch
from
a9550cc to
1c96542
Compare
auxesis
deleted the
fix/prevent-unsupported-sql-syntax-from-breaking-migrations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to disable and re-enable mapping for a connection
Disable mapping
Enable mapping
The
SETcommand is always scoped to the connectionSESSION- mapping is only ever disabled for the client connection theSETcommand was issued on.This also adds a prometheus metric called
STATEMENTS_PASSTHROUGH_MAPPING_DISABLED_TOTALthat tracks the count of statements passed through while mapping was disabled using this command.