Skip to content

Modularise SQL #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 17, 2025
Merged

Modularise SQL #99

merged 7 commits into from
Apr 17, 2025

Conversation

tobyhede
Copy link
Contributor

@tobyhede tobyhede commented Apr 14, 2025 •
edited by auxesis
Loading

Work in progress.

The story so far:

  • improved dependency management for sql files
  • smaller modules eg all ore types are now in src/ore/types.sql
  • ore data for better testing
  • additional test helpers to clean up testing
  • smarter test runner that can run single test file mise run test --test encrypted/functions

@tobyhede tobyhede force-pushed the eql-v2 branch 5 times, most recently from b10a353 to 11beed1 Compare April 16, 2025 06:16
@tobyhede tobyhede marked this pull request as ready for review April 16, 2025 06:24
@tobyhede tobyhede force-pushed the eql-v2 branch 3 times, most recently from 08a1b43 to ae27bf5 Compare April 16, 2025 06:39
@tobyhede tobyhede changed the title WIP Modularise SQL Apr 16, 2025
@tobyhede tobyhede force-pushed the eql-v2 branch 8 times, most recently from 4a04590 to dfe2838 Compare April 17, 2025 02:01
auxesis
auxesis approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@auxesis auxesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tobyhede!

@tobyhede tobyhede changed the base branch from main to eql-v2-0 April 17, 2025 04:29
@tobyhede tobyhede merged commit 71c86bb into eql-v2-0 Apr 17, 2025
4 checks passed
@tobyhede tobyhede deleted the eql-v2 branch April 17, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auxesis auxesis auxesis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobyhede @auxesis