Skip to content

Add docs on native PG JSON(B) functions/ops compared to EQL #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 7, 2024
Merged

Add docs on native PG JSON(B) functions/ops compared to EQL #61

merged 14 commits into from
Nov 7, 2024

Conversation

CDThomas
Copy link
Contributor

@CDThomas CDThomas commented Nov 5, 2024 •
edited
Loading

This PR adds docs that compare native Postgres JSON(B) functions and operators to JSON(B) support in EQL.

Functions and operators covered:

  • ->/->>
  • #>/#>>
  • @>/<@
  • json_array_elements, jsonb_array_elements, json_array_elements_text, and jsonb_array_elements_text
  • json_array_length

@CDThomas CDThomas force-pushed the add-docs-on-native-pg-json-vs-eql branch from 3fec02b to 7d79d60 Compare November 6, 2024 06:01
@CDThomas CDThomas force-pushed the add-docs-on-native-pg-json-vs-eql branch from 7d79d60 to 538ac13 Compare November 6, 2024 06:02
@CDThomas CDThomas marked this pull request as ready for review November 7, 2024 02:00
@CDThomas CDThomas changed the title Start docs on native PG JSON(B) support compared to EQL Add docs on native PG JSON(B) functions/ops compared to EQL Nov 7, 2024
freshtonic
freshtonic approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@freshtonic freshtonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work @CDThomas.

auxesis
auxesis requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@auxesis auxesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content is good, thanks @CDThomas.

I just have minor nits on terminology and formatting, which I've made suggestions for.

Please use the comments above each change as the commit message when you apply them.

CDThomas and others added 8 commits November 7, 2024 14:33
@CDThomas @auxesis
Refer to PostgreSQL consistently
c3ae969 
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
@CDThomas @auxesis
Punctuate consistently
0863b32 
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
@CDThomas @auxesis
Remove unneeded capitalisation
0fa808e 
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
@CDThomas @auxesis
Highlight technical terms
2b9989d 
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
@CDThomas @auxesis
Line per sentence, to improve maintainability
82b7ac6 
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
@CDThomas @auxesis
Split lines for maintainability & refer to PostgreSQL consistently
6bcb939 
Co-authored-by: Lindsay Holmwood <lindsay@cipherstash.com>
@CDThomas
Update eJSONPath docs in JSON.md
beabf2b 
Brought over from #15.
@CDThomas
Link to eJSONPath docs in native PG JSON(B) vs EQL docs
9224ad6
@CDThomas CDThomas requested a review from auxesis November 7, 2024 03:49
auxesis
auxesis approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@auxesis auxesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @CDThomas, approved.

@CDThomas CDThomas merged commit 9916110 into main Nov 7, 2024
@CDThomas CDThomas deleted the add-docs-on-native-pg-json-vs-eql branch November 7, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freshtonic freshtonic freshtonic approved these changes

@auxesis auxesis auxesis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CDThomas @freshtonic @auxesis