Skip to content

Raise exceptions if index fields are missing #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2024
Merged

Raise exceptions if index fields are missing #59

merged 2 commits into from
Nov 5, 2024

Conversation

tobyhede
Copy link
Contributor

@tobyhede tobyhede commented Nov 4, 2024

Index helper functions check for presence of the appropriate index field.
If not present, an exception is raised.

Also include some minor changes to align with naming conventions.

@tobyhede tobyhede force-pushed the CIP-864/validate-q-values branch from b149fee to 0654418 Compare November 4, 2024 05:44
freshtonic
freshtonic approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@freshtonic freshtonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

@tobyhede tobyhede merged commit 24a3d7f into main Nov 5, 2024
4 checks passed
@tobyhede tobyhede deleted the CIP-864/validate-q-values branch November 5, 2024 01:54
CDThomas added a commit that referenced this pull request Nov 5, 2024
@CDThomas
Add back GROUP BY support
6d1a55b 
`GROUP BY` support was accidentally removed in
#59.

This change adds back EQL functions for `GROUP BY` support.

Also see:
#55
@CDThomas CDThomas mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freshtonic freshtonic freshtonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobyhede @freshtonic