Skip to content

Cip 874 more jsonb queries #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 7, 2024
Merged

Cip 874 more jsonb queries #56

merged 7 commits into from
Nov 7, 2024

Conversation

yujiyokoo
Copy link
Contributor

@yujiyokoo yujiyokoo commented Nov 3, 2024 •
edited
Loading

This PR

  • adds more JSONB queries
  • moves the data creation so jsonb queries can run (currently there seems to be issues with null jsonb fields)
  • adds very simple unit tests to python code

to be done

  • refactor python code
  • Stop using CsText where it's not appropriate

@yujiyokoo yujiyokoo force-pushed the cip-874-more-jsonb-queries branch from 996f3af to 02d9442 Compare November 6, 2024 09:25
@yujiyokoo yujiyokoo marked this pull request as ready for review November 7, 2024 08:55
@calvinbrewer calvinbrewer merged commit 9c4c08a into main Nov 7, 2024
@calvinbrewer calvinbrewer deleted the cip-874-more-jsonb-queries branch November 7, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinbrewer calvinbrewer calvinbrewer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yujiyokoo @calvinbrewer