Update go xorm tests #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fimac
force-pushed
the
chore/update-go-xorm-tests
branch
from
dfcf480 to
3032832
Compare
fimac
commented
Oct 30, 2024
| @@ -26,28 +26,9 @@ subproject_teardown() { | |||
| docker compose down | |||
| } | |||
|
|
|||
| subproject_examples() { | |||
There was a problem hiding this comment.
Removed this command as no longer necessary (see comment in description). The tests are the source of truth for examples. No need to duplicate.
fimac
commented
Oct 30, 2024
|
|
||
| // Installing EQL | ||
| func installDsl(engine *sql.DB) { | ||
| path := "../../../release/cipherstash-encrypt-dsl.sql" |
There was a problem hiding this comment.
removed as this is now being installed on init of docker with a download directly from eql
fimac
commented
Oct 30, 2024
| installEql() | ||
| } | ||
|
|
||
| func runExamples() { |
There was a problem hiding this comment.
As noted in the description, these examples are duplicates of the e2e tests. Removing as there's no need for both, tests are the source of truth for working examples.
fimac
commented
Oct 30, 2024
| @@ -123,44 +123,6 @@ func (eb *EncryptedBoolField) FromDB(data []byte) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func setupDb() { | |||
There was a problem hiding this comment.
Unnecessary to have this. The db is created when docker starts
fimac
force-pushed
the
chore/update-go-xorm-tests
branch
from
4103247 to
70ed523
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.