Skip to content

Rename search term for consistency #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 22, 2025
Merged

Rename search term for consistency #109

merged 6 commits into from
May 22, 2025

Conversation

tobyhede
Copy link
Contributor

@tobyhede tobyhede commented May 22, 2025

Search terms are now

name code operators
hmac_256 hm eq
blake3 b3 eq
bloom_filter bf containment
ore_block_u64_8_256 ob lt lte eq gt gte
ore_cllw_u64_8 ocf lt lte eq gt gte
ore_cllw_u64_8 ocv lt lte eq gt gte
selector s path selector for encrypted json

@tobyhede tobyhede force-pushed the rename-fields branch 9 times, most recently from 1b87ef6 to 47c2a1a Compare May 22, 2025 06:44
@tobyhede tobyhede merged commit 7593787 into main May 22, 2025
4 checks passed
@tobyhede tobyhede deleted the rename-fields branch May 22, 2025 10:47
Copy link
Contributor

@yujiyokoo yujiyokoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some comments about formatting and comments

| `eql_v2.ore_64_8_v2(val)` | Extract ORE index from encrypted value | `SELECT eql_v2.ore_64_8_v2(encrypted_field)` |
| `eql_v2.ore_cllw_u64_8(val)` | Extract CLLW ORE index from encrypted value | `SELECT eql_v2.ore_cllw_u64_8(encrypted_field)` |
| `eql_v2.ore_cllw_var_8(val)` | Extract variable CLLW ORE index from encrypted value | `SELECT eql_v2.ore_cllw_var_8(encrypted_field)` |
| Function | Description | Exa mple |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like unnecessary spaces (and also in the lines below in this file)

$$ LANGUAGE plpgsql;


-- extracts unique index from an encrypted column
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be 'match'?





Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these blank lines needed here?

-- PERFORM assert_result(
-- 'ORDER BY eql_v2.ore_block_u64_8_256(e) ASC',
-- format('SELECT id FROM ore WHERE e < %L ORDER BY eql_v2.ore_block_u64_8_256(e) ASC LIMIT 1', ore_term),
-- '1');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have this deleted or an explanation added about its presence?

tobyhede added a commit that referenced this pull request May 23, 2025
Rename search term for consistency
PR_BYPASS: required for customer demo. minor changes to the names of several functions and internal fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants