Rename search term for consistency #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyhede
force-pushed
the
rename-fields
branch
9 times, most recently
from
1b87ef6 to
47c2a1a
Compare
yujiyokoo
reviewed
May 23, 2025
| | `eql_v2.ore_64_8_v2(val)` | Extract ORE index from encrypted value | `SELECT eql_v2.ore_64_8_v2(encrypted_field)` | | ||
| | `eql_v2.ore_cllw_u64_8(val)` | Extract CLLW ORE index from encrypted value | `SELECT eql_v2.ore_cllw_u64_8(encrypted_field)` | | ||
| | `eql_v2.ore_cllw_var_8(val)` | Extract variable CLLW ORE index from encrypted value | `SELECT eql_v2.ore_cllw_var_8(encrypted_field)` | | ||
| | Function | Description | Exa mple | |
There was a problem hiding this comment.
Looks like unnecessary spaces (and also in the lines below in this file)
| $$ LANGUAGE plpgsql; | ||
|
|
||
|
|
||
| -- extracts unique index from an encrypted column |
There was a problem hiding this comment.
Is this meant to be 'match'?
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Are these blank lines needed here?
| -- PERFORM assert_result( | ||
| -- 'ORDER BY eql_v2.ore_block_u64_8_256(e) ASC', | ||
| -- format('SELECT id FROM ore WHERE e < %L ORDER BY eql_v2.ore_block_u64_8_256(e) ASC LIMIT 1', ore_term), | ||
| -- '1'); |
There was a problem hiding this comment.
Could we have this deleted or an explanation added about its presence?
tobyhede
added a commit
that referenced
this pull request
May 23, 2025
Rename search term for consistency PR_BYPASS: required for customer demo. minor changes to the names of several functions and internal fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search terms are now