fix: Check m.room.encrypted permission for composer in encrypted rooms - #3092
Open
Yashh56 wants to merge 1 commit into
Open
fix: Check m.room.encrypted permission for composer in encrypted rooms#3092Yashh56 wants to merge 1 commit into
Yashh56 wants to merge 1 commit into
Conversation
|
Preview: https://3092--cinny-pr.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where standard users were prevented from composing or sending messages in encrypted rooms if the power level required for
m.room.messagewas elevated above their own (e.g. restricted to Admins).When a room is encrypted, users send
m.room.encryptedevents instead ofm.room.messageevents. Previously, theRoomViewcomponent unconditionally checked form.room.messagepermission to determine if the message composer should be rendered. This PR updates the logic to evaluate the correctm.room.encryptedpermission when E2EE is enabled.Changes
RoomView.tsxto determine the encryption state of the room usingmx.isRoomEncrypted(roomId).MessageEvent.RoomMessageEncrypted(m.room.encrypted) instead ofEventType.RoomMessagewhen the room is encrypted.Close: #3027