-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translation support using i18next #1576
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
7e0bac7
to
976fa61
Compare
ef92386
to
66fc90b
Compare
@aceArt-GmbH |
This is the initial part needed for translation. There are followup PRs (#1590, #1591, ...) which actually translate the keys in Cinny. |
66fc90b
to
cafb148
Compare
Hey, |
this PR is only the general setup, so it should be fine for merge. It would allow the refactored files to be translated The other PRs already contain translations of js files. Merging them wouldn't hurt, as the work is already done anyways. |
cafb148
to
c49fe1d
Compare
We could include a cache bust via |
c49fe1d
to
d8e295c
Compare
Preview: https://1576--pr-cinny.netlify.app |
Rebased and updated dependencies. So this is once again mergable |
d8e295c
to
d8372ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me.
I think we should also add language switcher in user settings so people can switch language of their choice without depending on system-language.
If you are fine with it, I would leave this to someone else and a separate PR |
Ok I will probably add it in another PR. Sorry for the review stuck so long behind refactor. Thanks for working on this! |
Description
Minimal version of #681.
Allows follow up PRs which add languages, translate components, language switcher or translator platform.
Fixes #164
Following https://locize.com/blog/react-i18next/
Type of change
Checklist: