Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation support using i18next #1576

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

aceArt-GmbH
Copy link
Contributor

Description

Minimal version of #681.
Allows follow up PRs which add languages, translate components, language switcher or translator platform.

Fixes #164

Following https://locize.com/blog/react-i18next/

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Dec 8, 2023

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@aceArt-GmbH
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Dec 8, 2023
@aceArt-GmbH aceArt-GmbH force-pushed the translate branch 2 times, most recently from ef92386 to 66fc90b Compare December 11, 2023 11:39
@aceArt-GmbH aceArt-GmbH mentioned this pull request Dec 15, 2023
9 tasks
@aceArt-GmbH
Copy link
Contributor Author

@ajbura @kfiven can I get some feedback on this PR? :)

@Hakira-Shymuy
Copy link

@aceArt-GmbH
is possible with this to translate ?
i would like to provide Portuguese ( PT-PT ) translation

@aceArt-GmbH
Copy link
Contributor Author

@aceArt-GmbH is possible with this to translate ? i would like to provide Portuguese ( PT-PT ) translation

This is the initial part needed for translation. There are followup PRs (#1590, #1591, ...) which actually translate the keys in Cinny.
So you could prepare a Portuguese translation, but as none of this is merged yet, you might have to redo some translations

@ajbura
Copy link
Member

ajbura commented Dec 22, 2023

Hey,
We were planing to add translation after next release because Cinny is undergoing major TS refactor. So if you are added translation please keep it to only.ts files as much as possible, because other stuff is going to change repeatedly.

@aceArt-GmbH
Copy link
Contributor Author

this PR is only the general setup, so it should be fine for merge. It would allow the refactored files to be translated

The other PRs already contain translations of js files. Merging them wouldn't hurt, as the work is already done anyways.
And you can copy the keys on refactor

@aceArt-GmbH
Copy link
Contributor Author

We could include a cache bust via queryStringParams: { v: cons.version },

Copy link

github-actions bot commented Feb 19, 2024

Preview: https://1576--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@aceArt-GmbH
Copy link
Contributor Author

Rebased and updated dependencies. So this is once again mergable

Copy link
Member

@ajbura ajbura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

I think we should also add language switcher in user settings so people can switch language of their choice without depending on system-language.

@aceArt-GmbH
Copy link
Contributor Author

Everything looks good to me.

I think we should also add language switcher in user settings so people can switch language of their choice without depending on system-language.

If you are fine with it, I would leave this to someone else and a separate PR

@ajbura
Copy link
Member

ajbura commented Aug 14, 2024

Ok I will probably add it in another PR. Sorry for the review stuck so long behind refactor.

Thanks for working on this!

@ajbura ajbura merged commit ac17973 into cinnyapp:dev Aug 14, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
@aceArt-GmbH aceArt-GmbH deleted the translate branch September 12, 2024 06:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for translation
3 participants