Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown example #16

Merged
merged 11 commits into from
Jul 2, 2016
Merged

Markdown example #16

merged 11 commits into from
Jul 2, 2016

Conversation

mb720
Copy link

@mb720 mb720 commented Jun 26, 2016

Hi!

I'd like to contribute an example that uses marked to convert Markdown text to HTML in the browser using JSweet.

I've added a new index.html in webapp/markdown. The Java file being transpiled to JavaScript is examples/markdown/MarkdownExample.java.

I had to comment out ToDos.java since it wouldn't compile.

I took the liberty to adapt build.gradle so we can use the Gradle wrapper now. The instructions for trying out the examples thus become:

  1. git clone https://github.com/cincheo/jsweet-examples.git
  2. cd jsweet-examples
  3. ./gradlew jsweet (Gradle is not required to be installed)
  4. Open the desired index.html in the webapp directory with the browser of your choice

@lgrignon
Copy link
Collaborator

Nice example. Thanks.

@renaudpawlak
Copy link
Contributor

So, you managed to fix the issue in the web browser?
Github says there is a conflict... maybe you should try to sync your repo and submit again the PR. Normally I have fixed the backbone example... maybe the conflict comes from it?

@mb720
Copy link
Author

mb720 commented Jun 30, 2016

Thanks!

I'll sync with the repo and make another PR this week or the next (I'm a bit busy at the moment).

What issue in the web browser are you referring to, @renaudpawlak?

@mb720
Copy link
Author

mb720 commented Jun 30, 2016

Thanks for fixing ToDos.java, Renaud!
I merged my changes with yours.

I removed this comment from ToDos.java since I think it doesn't apply anymore:

    // TODO: the Store class in backbone does not define any parameter in the
    // constructor... maybe a mistake in the original TypeScript exammle, which
    // declare the Store class as an "any" variable...
    // Store localStorage = new Store("todos-backbone");

@renaudpawlak renaudpawlak merged commit f2f4256 into cincheo:master Jul 2, 2016
@renaudpawlak
Copy link
Contributor

Thank you very much. I merged and I will check later if it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants