Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/search operators #42

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

javierlores
Copy link
Contributor

Added support for search_match and search exclude operators

@jtnelson
Copy link
Member

@javierlores

Can you also add the following aliases:

  • CONTAINS => SEARCH_MATCH
  • NOT_CONTAINS => SEARCH_EXCLUDE

@jtnelson
Copy link
Member

jtnelson commented May 2, 2024

@javierlores More merge conflicts. Can you please fix?

@jtnelson
Copy link
Member

jtnelson commented May 2, 2024

Also @javierlores is it possible to make it so that SEARCH_MATCH, SEARCH_EXCLUDE, etc can only be used in statements that have a simple key (e.g., no navigation key and no function key) AND only have one value AND don't have a timestamp?

@javierlores
Copy link
Contributor Author

javierlores commented May 2, 2024

@jtnelson Merged conflicts resolved.

It should be possible, let me see if I can figure it out

@jtnelson
Copy link
Member

@javierlores A few changes after I've thought about this more

  • Lets allow CONTAINS, NOT_CONTAINS, etc to have a timestamp

@javierlores
Copy link
Contributor Author

@jtnelson Sounds good, won't implement that then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants