add context to the task function signature #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are use-cases where the caller does not care about the results of tasks processing and thus never calls the Drain method. This is typically the case for tasks that are never expected to return unless a context is cancelled. To accommodate for this use-case, add a context as a parameter to the task function. As tasks are now allowed to run forever unless the context is cancelled, ensure that calling the Close method cancels the tasks context to properly tear down all workers. It is the responsibility of the library user to ensure submitted tasks respect the context. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are use-cases where the caller does not care about the results of
tasks processing and thus never calls the Drain method. This is
typically the case for tasks that are never expected to return unless a
context is cancelled. To accommodate for this use-case, add a context as
a parameter to the task function.
As tasks are now allowed to run forever unless the context is cancelled,
ensure that calling the Close method cancels the tasks context to
properly tear down all workers. It is the responsibility of the library
user to ensure submitted tasks respect the context.