-
Notifications
You must be signed in to change notification settings - Fork 441
make gen_compile_commands for tetragon #3698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@0xMALVEE Thank you for the PR. For reference, here are the guidelines for commits in the Tetragon project: https://tetragon.io/docs/contribution-guide/submitting-a-pull-request/#commit-changes If you could write a more descriptive commit message that would be great, but IMO it's also fine to merge as is. |
141b059
to
bd9f72e
Compare
@lambdanis updated the commit according to commit guidelines. <3 |
c9fe331
to
14ebc40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xMALVEE 👋🏼
Could you please fix the checkpatch
warnings?
14ebc40
to
c676a93
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
c676a93
to
5dfa815
Compare
I'm sorry this is still failing, I think you need to do that: -Signed-off-by: M Alvee <m.alvee8141@gmail.com>
-Co-Authored-By: Kornilios Kourtis <kkourt@users.noreply.github.com>
+Co-authored-By: Kornilios Kourtis <kkourt@users.noreply.github.com>
+Signed-off-by: M Alvee <m.alvee8141@gmail.com> remove A in authored, and maybe switch co-authored and signed-off. Sorry I know this is a bit annoying |
5dfa815
to
c80f100
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
:( Indeed very annoying. Feel free to remove it :) |
oh my... I missed the uppercase B in my reco sorry |
c80f100
to
cff8e9f
Compare
I have updated with "b" |
I think the project should have pre commit hooks to check commits details when user comits, rather then in github actions. What you guys think |
Tetragon project doesn't have a command to generate compile_commands.json for clang. This commit fixes that by: 1. Adding make gen_compile_commands just like in cilium Fixes: cilium#3697 Co-authored-by: Kornilios Kourtis <kornilios@isovalent.com> Signed-off-by: M Alvee <m.alvee8141@gmail.com>
Yeah that could be an idea maybe just having a target for first contributors to trigger checkpatch and such static checks could be an idea as well (looking at the static-checks YAML GitHub actions could give an idea, in addition to checkpatch). Unrelated to this, sorry the contribution was such a poor experience, I admit for this kind of patch, it should have been merged quickly and you shouldn't have to do all these edits! Sorry, I hope you still want to contribute to Tetragon :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully this passes CI and we can merge this :)
Fixes
#3697
Description
just like in cilium, make gen_compile_commands will generate compile_commands.json using bear.
It's used for some IDE to analyze codebase better and ensure no linting errors are shown by following includes paths