Skip to content

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Dec 16, 2024

@michi-covalent michi-covalent added the release-note/docs This PR updates the documentation. label Dec 16, 2024
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 212aa9c
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6760de0706fd6900085f7259
😎 Deploy Preview https://deploy-preview-3231--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@michi-covalent michi-covalent marked this pull request as ready for review December 16, 2024 16:36
@michi-covalent michi-covalent requested review from a team and mtardy as code owners December 16, 2024 16:36
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks that's a great addition! I have a comment, let me know what you think. I think you don't need to change what you submitted but just as food for thoughts. Or maybe putting a little warning.

```shell
brew install lima
limactl create --tty=false --name=tetragon \
--set='.vmType = "vz" | .nestedVirtualization = true | .mounts[] |= (select(.location == "~") | .writable = true)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think vz might be the default now with lima 1.0, and that nestedVirt is not strictly needed in our situation. Also not sure if it's a good idea to recommend mounting the whole home folder as writable, I think they made it read only in the past because of potential issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool i'll update it.

i guess there is a way to only make the tetragon directory writable? 💭

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's start with this ☕

Screenshot 2024-12-17 at 11 14 55 AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just created this #3237 for using warning and note, I think that looks more native to the docs :)

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent merged commit 5047c19 into main Dec 17, 2024
10 checks passed
@michi-covalent michi-covalent deleted the pr/michi/mac branch December 17, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/docs This PR updates the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants