github: Add "Image Release Build" workflow #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
added
the
release-note/misc
gandro
force-pushed
the
pr/gandro/build-images-in-gh-actions
branch
from
5700473
to
34174c7
Compare
gandro
force-pushed
the
pr/gandro/build-images-in-gh-actions
branch
from
12b0535
to
9744742
Compare
gandro
force-pushed
the
pr/gandro/build-images-in-gh-actions
branch
from
9744742
to
ce30a24
Compare
gandro
force-pushed
the
pr/gandro/build-images-in-gh-actions
branch
from
ce30a24
to
5f2379c
Compare
|
Note: I tried to add support for arm64, but it seems like the arm64 alpine base images have some issues when running on x86-based GitHub Actions: https://gitlab.alpinelinux.org/alpine/aports/-/issues/12406 |
This adds a workflow to build the release images via GitHub actions, instead of relying on the quay.io autobuilder. The quay.io autobuilder often fails due to DockerHub's rate limiting on the golang builder base image. By using our own Docker credentials, we can avoid hitting the rate limit. The workflow heavily based on the one found in `cilium/cilium`, with only minor modifications (i.e. only building a single image, only pushing to quay.io) and is similar to the one used by Hubble UI. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/build-images-in-gh-actions
branch
from
5f2379c
to
52c8c7b
Compare
|
Quay credentials have been added. This only pushes to quay, as we never had a DockerHub image for the Hubble CLI. Successful run demonstrating credentials and build works (with Docker |
gandro
force-pushed
the
pr/gandro/build-images-in-gh-actions
branch
from
52c8c7b
to
6c5906b
Compare
gandro
requested review from
a team,
nebril and
nbusseneau
and removed request for
a team
nbusseneau
approved these changes
Sep 20, 2021
Yes. This is the commit which led to the successful run that I linked above (#627 (comment)): |
|
Ah sorry I missed the comment linking to a successful run 🙈 |
nebril
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a workflow to build the release images via GitHub actions,
instead of relying on the quay.io autobuilder.
The quay.io autobuilder often fails due to DockerHub's rate
limiting on the golang builder base image. By using our own
Docker credentials, we can avoid hitting the rate limit.
The workflow heavily based on the one found in
cilium/cilium, withonly minor modifications (i.e. only building a single image, only
pushing to quay.io) and is similar to the one used by Hubble UI.