cmd/record: Add stop condition flags #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
added
the
release-note/minor
gandro
requested review from
joamaki and
rolinh
and removed request for
a team
This pulls in the Hubble API definitions from cilium/cilium#16473 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
This adds three new flags to the `hubble record` subcommand: - `packet-limit`: Stops the recording after a specified number of packets have been recorded. - `bytes-limit`: Stops the recording after a specified number of bytes have been recorded. - `time-limit`: Stops the recording after a specified duration has elapsed. The first limit to hit will stop the recording. If none of the three flags are specified, then the recording needs to be stopped manually. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/recorder-stop-condition
branch
from
e2245b3
to
6722b09
Compare
glibsm
reviewed
Aug 11, 2021
| @@ -80,6 +86,10 @@ protocols are TCP, UDP and ANY.`, | |||
| recorderFlags.StringVar(&fileSinkPrefix, "file-prefix", "hubble", "File prefix of the resulting pcap file") | |||
| recorderFlags.Uint32Var(&maxCaptureLength, "max-capture-len", 0, "Sets the maximum capture length (zero for full capture)") | |||
|
|
|||
| recorderFlags.Uint64Var(&packetLimit, "packet-limit", 0, "Sets a limit on how many packets to capture on each node") | |||
| recorderFlags.Uint64Var(&bytesLimit, "bytes-limit", 0, "Sets a limit on how many bytes to capture on each node") | |||
| recorderFlags.DurationVar(&timeLimit, "time-limit", 0, "Sets a limit on how long to capture on each node") | |||
There was a problem hiding this comment.
does this do the relative nifty things like 10s, 5m etc?
There was a problem hiding this comment.
Yes. This is using the same mechanism as --since
Duration flags accept any input valid for time.ParseDuration.
https://pkg.go.dev/flag
rolinh
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three new flags to the
hubble recordsubcommand:packet-limit: Stops the recording after a specified number ofpackets have been recorded.
bytes-limit: Stops the recording after a specified number ofbytes have been recorded.
time-limit: Stops the recording after a specified durationhas elapsed.
The first limit to hit will stop the recording. If none of the three
flags are specified, then the recording needs to be stopped manually.
These flags are only supported by Cilium master at the moment, see
cilium/cilium#16473 for the API implementation.