Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/observe: remove depreacted formatting flags (json, compact, dict) #603

Merged
merged 1 commit into from
Aug 10, 2021
Merged

cmd/observe: remove depreacted formatting flags (json, compact, dict) #603

merged 1 commit into from
Aug 10, 2021

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Aug 9, 2021

This patch completely removes the --json, --compact and --dict flags that have been deprecated since version v0.5.0 release 1.5 year ago. See this discussion for additional context.

@rolinh
cmd/observe: remove depreacted formatting flags (json, compact, dict)
4bd0e3c 
This patch completely removes the `--json`, `--compact` and `--dict`
flags that have been deprecated since version v0.5.0 release 1.5 year
ago.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh added ⌨️ area/cli Impacts the command line interface of any command in the repository. release-note/misc This PR makes changes that have no direct user impact. labels Aug 9, 2021
@rolinh rolinh requested review from gandro and a team August 9, 2021 12:51
gandro
gandro approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Leaving this open for a while for others to give their input as well, if they want.

@rolinh rolinh added the needs-backport/0.8 This PR needs backporting to the v0.8 branch. label Aug 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 10, 2021
@gandro gandro merged commit a5c439a into master Aug 10, 2021
@gandro gandro deleted the pr/rolinh/remove-deprecated-formatting-flags branch August 10, 2021 08:15
@rolinh rolinh mentioned this pull request Aug 10, 2021
Merged
@rolinh rolinh added backport-pending/0.8 The backport for Hubble 0.8.x for this PR is in progress. backport-done/0.8 The backport for Hubble 0.8.x for this PR is done. and removed needs-backport/0.8 This PR needs backporting to the v0.8 branch. backport-pending/0.8 The backport for Hubble 0.8.x for this PR is in progress. labels Aug 10, 2021
@rolinh rolinh mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@glibsm glibsm glibsm approved these changes

@gandro gandro gandro approved these changes

Assignees
No one assigned
Labels
⌨️ area/cli Impacts the command line interface of any command in the repository. backport-done/0.8 The backport for Hubble 0.8.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rolinh @gandro @glibsm @tklauser