Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable checks for missing Go documentation #581

Merged
merged 2 commits into from
Jun 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Run static checks
uses: golangci/golangci-lint-action@v2
with:
version: v1.40.1
version: v1.41.1
args: --config=.golangci.yml --verbose
skip-go-installation: true
skip-pkg-cache: true
Expand Down
7 changes: 7 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ linters-settings:
go: "1.16"

issues:
# Default rules exclude Go doc comments check, which is rather unfortunate.
# In order to enable Go doc checks, defaults rules have to be disabled.
# See https://github.com/golangci/golangci-lint/issues/456 for details.
exclude-use-default: false
exclude:
- (G104|G307) # EXC0008 gosec: Duplicated errcheck checks

exclude-rules:
- linters: [staticcheck]
text: "SA1019" # deprecated methods
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ RELEASE_GID ?= $(shell id -g)

TEST_TIMEOUT ?= 5s

GOLANGCILINT_WANT_VERSION = 1.40.1
GOLANGCILINT_WANT_VERSION = 1.41.1
GOLANGCILINT_VERSION = $(shell golangci-lint version 2>/dev/null)

all: hubble
Expand Down