cmd/observe: move flows specific code to flows*.go files #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up for commit 700d6bc ("cmd/observe: rename flow-related functions and types"), separated to ease review. This separates the generic observe functionality from the functionality specific to flows. This follows the file naming scheme used for agent and debug events. No functional changes. This is preparatory refactoring for the introduction of the `hubble observe flows` subcommand. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
the
area/misc
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
tklauser
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
rolinh
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second round of refactoring for #543.
Follow-up for commit 700d6bc ("cmd/observe: rename flow-related
functions and types"), separated to ease review.
This separates the generic observe functionality from the functionality
specific to flows. This follows the file naming scheme used for agent
and debug events.
No functional changes. This is preparatory refactoring for the
introduction of the
hubble observe flowssubcommand.