cmd/observe: rename flow-related functions, types and import aliases #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it clear that the respective functions and types are applying to flows and follows the naming scheme used for agent and debug events. No functional changes. This is preparatory refactoring for the introduction of the `hubble observe flows` subcommand. Generated automatically using: ``` gorename -from '"github.com/cilium/hubble/cmd/observe".observeFilter' -to flowFilter gorename -from '"github.com/cilium/hubble/cmd/observe".newObserveFilter' -to newFlowFilter gorename -from '"github.com/cilium/hubble/cmd/observe".handleArgs' -to handleFlowArgs gorename -from '"github.com/cilium/hubble/cmd/observe".eventTypes' -to flowEventTypes gorename -from '"github.com/cilium/hubble/cmd/observe".newObserveCmd' -to newFlowsCmd gorename -from '"github.com/cilium/hubble/cmd/observe".getRequest' -to getFlowsRequest ``` Signed-off-by: Tobias Klauser <tobias@cilium.io>
The package cmd/observe is no longer just about observing flows, so make the import alias more explicit. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
the
release-note/misc
rolinh
approved these changes
Jun 22, 2021
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparatory refactoring for #543, split into a separate PR to ease review.
See individual commit messages for details.