cmd/observe: do not set --last to 20 by default in follow mode
#573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the default behavior with regard to `--last` when in follow mode.
Previously, running `hubble --debug observe --folloow` resulted in the
following:
$ hubble --debug observe --follow
time="2021-06-17T16:20:25+02:00" level=debug msg="Sending GetFlows request" request="number:20 follow:true"
The new behavior is changed for the following (notice that `number` is
not set, ie 0):
$ hubble --debug observe --follow
time="2021-06-17T16:21:02+02:00" level=debug msg="Sending GetFlows request" request="follow:true"
There are use-cases where a user is not interested in events that are
already in Hubble's ring buffer cache but only in new ones. A typical
example is when using hubble for testing, e.g. for the connectivity
test.
Note that this PR is a slight change of behavior as, when `--last` is
not provided, it used to always default to 20 unless `--since` or
`--until` is provided.
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
added
⌨️ area/cli
gandro
approved these changes
Jun 17, 2021
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default behavior with regard to
--lastwhen in follow mode.Previously, running
hubble --debug observe --followresulted in thefollowing:
The new behavior is changed for the following (notice that
numberisnot set, ie 0):
There are use-cases where a user is not interested in events that are
already in Hubble's ring buffer cache but only in new ones. A typical
example is when using hubble for testing, e.g. for the connectivity
test.
Note that this PR is a slight change of behavior as, when
--lastisnot provided, it used to always default to 20 unless
--sinceor--untilis provided.