pkg/printer: disable color output in tests #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on how `go test` is invoked, the auto-detection in the `github.com/fatih/color` library will enable/disable color support. For example when invoked as `go test .` in the `pkg/printer` directory, color output will be enabled while for running `go test ./...` in the root directory color support is disabled. Avoid this flaky behavior by disabling color output in all printer tests. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
the
release-note/misc
kaworu
approved these changes
May 31, 2021
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on how
go testis invoked, the auto-detection in thegithub.com/fatih/colorlibrary will enable/disable color support. Forexample when invoked as
go test .in thepkg/printerdirectory,color output will be enabled while for running
go test ./...in theroot directory color support is disabled.
Avoid this flaky behavior by disabling color output in all printer
tests.