Makefile: Introduce GO_BUILD variable #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
gandro
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
rolinh
reviewed
May 27, 2021
gandro
force-pushed
the
pr/gandro/use-go-build-variable
branch
from
ad0f84b
to
0084a06
Compare
Good catch. Done and tested! |
kaworu
approved these changes
May 27, 2021
maintainer-s-little-helper
bot
added
the
ready-to-merge
kaworu
added
needs-rebase
maintainer-s-little-helper
bot
added
the
ready-to-merge
rolinh
removed
the
ready-to-merge
This allows users to overwrite the GO environment variable while still using CGO_ENABLED=false. This for example is useful when testing pre-releases of the Go compiler. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/use-go-build-variable
branch
from
0084a06
to
4efa821
Compare
gandro
added
ready-to-merge
needs-rebase
rolinh
approved these changes
May 27, 2021
tklauser
added a commit
to cilium/cilium-cli
that referenced
this pull request
Jul 14, 2021
This allows users to overwrite the GO environment variable while still using CGO_ENABLED=0. This for example is useful when testing pre-releases of the Go toolchain, e.g. `make GO=go1.17rc1`. Follows cilium/hubble#560 Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added a commit
to cilium/cilium-cli
that referenced
this pull request
Jul 14, 2021
This allows users to overwrite the GO environment variable while still using CGO_ENABLED=0. This for example is useful when testing pre-releases of the Go toolchain, e.g. `make GO=go1.17rc1`. Follows cilium/hubble#560 Signed-off-by: Tobias Klauser <tobias@cilium.io>
aditighag
pushed a commit
to aditighag/cilium-cli
that referenced
this pull request
Apr 21, 2023
This allows users to overwrite the GO environment variable while still using CGO_ENABLED=0. This for example is useful when testing pre-releases of the Go toolchain, e.g. `make GO=go1.17rc1`. Follows cilium/hubble#560 Signed-off-by: Tobias Klauser <tobias@cilium.io>
michi-covalent
pushed a commit
to michi-covalent/cilium
that referenced
this pull request
May 30, 2023
This allows users to overwrite the GO environment variable while still using CGO_ENABLED=0. This for example is useful when testing pre-releases of the Go toolchain, e.g. `make GO=go1.17rc1`. Follows cilium/hubble#560 Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to overwrite the GO environment variable while still
using CGO_ENABLED=false. This for example is useful when testing
pre-releases of the Go compiler.