Use golangci-lint for static checks #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
The golint repository is unfortunately no longer maintained. The golangci-lint project offers many static check tools that implement checks that we had enabled via various tools. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
All the static checks that were performed by these tools are covered by golangci-lint with the given config (and more). Therefore, remove now obsolete make targets and update the `check` target to run golangci-lint instead. Note that as it is not recommended to instsall golangci-lint via source, the target runs the binary when the expected version is found and via a docker container otherwise. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
added
kind/enhancement
glibsm
reviewed
May 26, 2021
|
|
||
| vet: | ||
| go vet $$(go list ./...) | ||
| ifneq (,$(findstring $(GOLANGCILINT_WANT_VERSION),$(GOLANGCILINT_VERSION))) |
There was a problem hiding this comment.
should we use some sort of semver comp here, i.e. 1.40.2 should be ok too, right? Or do we specifically want the exact match
There was a problem hiding this comment.
Sure, I can drop PATCH from the version check although that would make the code a bit more complicated.
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details. These changes are loosely based on the changes made to cilium-cli via #229.