script: Allow setting env var value from stdout

[christarazi]

This is useful if there are commands that output values that could be
used as parameters to subsequent commands.

Also modify the scripttest runner when verbose mode is set to execute
the "env" command using ExecuteLine() instead of running Env() directly
because we now need the flags to be initialized.

Signed-off-by: Chris Tarazi chris@isovalent.com

[christarazi]

cc @joamaki

[pippolo84]

Overall LGTM ✅

I'd suggest to add a test for env like the following:

# set an env var
env TEST=value
env TEST
cmp stdout stdout_env.txt

# set an env var from stdout
echo hello
env --from-stdout TEST
env TEST
cmp stdout stdout_env_stdout.txt

# set multiple env vars from stdout
echo world
env --from-stdout TEST1 TEST2
env TEST1
cmp stdout stdout_env_stdout_1.txt
env TEST2
cmp stdout stdout_env_stdout_2.txt

-- stdout_env.txt --
TEST=value
-- stdout_env_stdout.txt --
TEST=hello
-- stdout_env_stdout_1.txt --
TEST1=world
-- stdout_env_stdout_2.txt --
TEST2=world

[christarazi]

@pippolo84 I agree with adding tests but I don't see any other command being tested in a txtar-style test (unless I've missed it somehow). Is this something we still want to do? I'm not sure if this was a specific reason to not have these kinds of tests in this repo.

[pippolo84]

@pippolo84 I agree with adding tests but I don't see any other command being tested in a txtar-style test (unless I've missed it somehow). Is this something we still want to do? I'm not sure if this was a specific reason to not have these kinds of tests in this repo.

I see a .txtar based test for Empty and Sed, for example. I'm not aware of any limitation regarding script based tests for commands, but let's hear from @joamaki too.

[christarazi]

@pippolo84 Ah thanks for the pointer, I missed those files. I added what you suggested and credited you in the commit, thanks!