Skip to content

link: add Detach() #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

link: add Detach() #1830

wants to merge 4 commits into from

Conversation

florianl
Copy link
Contributor

Add bpf_link_detach() functionality.

Signed-off-by: Florian Lehner <dev@der-flo.net>
@florianl florianl requested review from mmat11 and a team as code owners July 26, 2025 11:19
@mmat11
Copy link
Contributor

mmat11 commented Jul 26, 2025

I see that iter links (and probably other) don't support Detach(); should we add a test for one of these cases? also, should we explicitly return ErrNotSupported?

florianl added 2 commits July 28, 2025 19:10
Signed-off-by: Florian Lehner <dev@der-flo.net>
Signed-off-by: Florian Lehner <dev@der-flo.net>
@florianl
Copy link
Contributor Author

sorry for the delayed response 🙏

I see that iter links (and probably other) don't support Detach(); should we add a test for one of these cases?

With 2520bb8 I have added such a test.

[..] should we explicitly return ErrNotSupported?

With c92c648 I have added an error wrapper. Hope this is fine for you.

Signed-off-by: Florian Lehner <dev@der-flo.net>
@mmat11
Copy link
Contributor

mmat11 commented Jul 28, 2025

lgtm! there are some failing CI jobs, not sure they are related

@florianl
Copy link
Contributor Author

there are some failing CI jobs, not sure they are related

They don't seem to be related:

=== FAIL: asm  (0.00s)
panic: test timed out after 10m0s
	running tests:
		TestGetSetJumpOp (10m0s)

This is also reported in #1734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants