cmd/bpf2go: Use BPF2GO_CFLAGS instead of BPF2GO_FLAGS #1796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix docs and Makefile that reference BPF2GO_FLAGS. Use BPF2GO_CFLAGS instead. Signed-off-by: Jordan Rife <jrife@google.com>
This rewrites file paths in DWARF, but bpf2go calls llvm-strip on all objects, which removes this info anyway. Other Makefile targets do the same thing. llvm-objdump -SD seems to understand bpf lineinfo for annotating insns with source info, so this flag isn't that useful anymore. Signed-off-by: Timo Beckers <timo@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix docs and Makefile that reference
BPF2GO_FLAGS. UseBPF2GO_CFLAGSinstead.